1. Is the joycon stick drifting issue, the dock warping issue, and the Switch screen warping issue fixed in the latest production models?
I'm not sure. I bought my Switch in June of 2017, and I haven't encountered the dock or screen warping issues. I did, however, have to send one of my original joycons off for repairs becausde of the stick drifting issue. I also have the Japanese green/pink Splatoon joycons and haven't had any issues with those, but that might just be because my usage is split accross two pairs of joyconsa, a pro-controller and the NES controllers now, so no single joycon has to stand up to the strain of constant play.
3. Is a 128GB card enough if I am going to buy the majority of my games on a cart?
Probably depends on how many games you plan to buy and how heavily you favor physical vs digital. I bought a 128 soon after getting the system and I finally maxed it out a month or sop ago and had to archive a few larger games. The thing that killed me was I bought a few huge third party games (Doom, Wolfenstein, LA Noire, etc.) digital because the eshop sales for those titles were better than the physical sales. If you're going to stick to indies and first party games (which are usually shockingly well optimized) you can probably make 128 GB last for a very long time.
9. Is the Switch Pro Controller overall a good controller? I am hesitant based on what I've heard of the d-pad and I am not fond of asymmetrical sticks. I was considering the 8Bitdo SN30 Pro as well.
The pro-controller is, hands down, the best controller I've ever used. Yes, the d-pad sucks, but the form factor is awesome, it's incredibly durable, has amazing battery life, HD rumble (which is way cooler than it sounds), gyro, perfect button placement, and, honestly, it's just ideal in almost every possible way. So, unless you plan to play a lot of old school 2D platformers or puzzle games that demand absolute precision from the D-pad, I would unequivocally recommend it.
(BTW, if you do plan to play hours of, say, Shovel Knight or Tetris 99, I think the best option would be the much-maligned NES controllers that you can buy if you're a Switch Online member. That is, assuming you can play the game in question with *just* the d-pad, A, B, L, and R buttons.)