Not saying that will or won't happen, but impeaching Bill Clinton had an opposite effect which made him more popular afterwards.It always seemed to me that getting 67 votes in the Senate was going to be the most difficult thing to accomplish given the right wing apathy to Trump. I fully expect a Democratic House to successfully impeach him in 2019 though.
I also fully expect Trump to limp his presidency on to 2020 essentially as a lame duck.